Minor fixes v14 (Western Plaguelands WPL)

[Stiga]

Not working yet as the smart script fix for some reason is not working - posting to see if better/cleverer people can spot the problem and fix it.
I posted a temp work-a-round solution below

Quest *** NOT WORKING fix for the moment ***
https://www.wowhead.com/quest=27089/ace-in-the-hole -- no Val'kyr summoned when accepting quest (required to complate quest)
I checked and there was no smart script associated to the npc/quest. Therefore I added one but unfortunately even though the spells are correct (tested ingame) the script doesn't work.
Maybe someone can find the problem. I assumed this required a smart script though I could be wrong!
For example a previous quest https://www.wowhead.com/quest=26955/zenkiki-and-the-cultists uses a smart script to summon a helper. I based the below script on that one.

smart_scripts - TrinityCore - Confluence

trinitycore.atlassian.net

-- https://www.wowhead.com/quest=27089/ace-in-the-hole -- missing smart script to summon valkyr -- https://www.wowhead.com/spell=84198/summon-enthralled-valkyr
-- https://www.wowhead.com/spell=84191/despawn-enthralled-valkyr-guardian (possible despawn spell to verify)
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES (44451, 0, 0, 0, 19, 0, 100, 0, 27089, 0, 0, 0, 0, 85, 84198, 4, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 'Lady Sylvanas quest accepted - Cast summon Enthralled Valkyr');

https://www.wowhead.com/quest=27089/ace-in-the-hole -- Missng npc and wrong faction for quest (however requires Val'kyr see above) -- https://www.wowhead.com/npc=45101/frightened-provincial-minuteman

-- https://www.wowhead.com/npc=45101/frightened-provincial-minuteman
UPDATE creature_template SET faction_a=14 WHERE entry=45101; -- value was 35 -- fixes faction horde hostile
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1471.44, -1714.42, 69.8933, 2.39023, 300, 0, 0, 762, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1462.29, -1723.07, 68.9492, 1.25141, 300, 0, 0, 730, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1442.13, -1715.41, 69.7285, 0.383541, 300, 0, 0, 762, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1443.22, -1694.56, 68.9065, 5.77137, 300, 0, 0, 730, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1471, -1696.11, 69.0433, 3.21098, 300, 0, 0, 762, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1451.87, -1657.74, 69.8518, 3.28009, 300, 0, 0, 762, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1447.94, -1641.27, 69.0595, 4.42678, 300, 0, 0, 730, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1426.26, -1648.11, 69.5397, 5.93081, 300, 0, 0, 762, 0, 0, 0, 0, 0, 0, 0);
SELECT MAX(guid)+1 into @var FROM creature;
INSERT INTO `creature` (`guid`, `id`, `map`, `zone`, `area`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `walkmode`, `saiscriptflag`) VALUES (@var, 45101, 0, 28, 193, 1, 8, 0, 0, 1434.49, -1663.94, 69.1832, 1.02207, 300, 0, 0, 730, 0, 0, 0, 0, 0, 0, 0);

Quest
Work-a-round temp fix https://www.wowhead.com/quest=27089/ace-in-the-hole work-a-round (only https://www.wowhead.com/npc=44453/thassarian working)

--[URL='https://www.wowhead.com/quest=27089/ace-in-the-hole'] [/URL][URL='https://www.wowhead.com/quest=27089/ace-in-the-hole']https://www.wowhead.com/quest=27089/ace-in-the-hol[/URL]e work-a-round (only[URL='https://www.wowhead.com/npc=44453/thassarian'] [/URL][URL='https://www.wowhead.com/npc=44453/thassarian']https://www.wowhead.com/npc=44453/thassaria[/URL]n working)
UPDATE quest_template SET RequiredNpcOrGo1 = 0 WHERE id=27089; -- value was 45102
UPDATE quest_template SET RequiredNpcOrGoCount1 = 0 WHERE id=27089; -- value was 5
UPDATE quest_template SET RequiredNpcOrGo2 = 0 WHERE id=27089; -- value was 45103
UPDATE quest_template SET RequiredNpcOrGoCount2 = 0 WHERE id=27089; -- value was 5

Quest
https://www.wowhead.com/quest=27144/the-reckoning -- event not working so work-a-round

-- https://www.wowhead.com/quest=27144/the-reckoning -- event not working so work-a-round
UPDATE quest_template SET RequiredNpcOrGo1 = 0 WHERE id=27144; -- value was 45111
UPDATE quest_template SET RequiredNpcOrGoCount1 = 0 WHERE id=27144; -- value was 1

 

[ExO]

Executed parts of it. I'll try to research your todo notes

 

[warcraftlife]

Thx!